Skip to content

Add lines parser #3511

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 8 commits into from
Sep 13, 2023
Merged

Add lines parser #3511

merged 8 commits into from
Sep 13, 2023

Conversation

mavam
Copy link
Member

@mavam mavam commented Sep 13, 2023

This PR adds a lines parser that chops up its input at newlines.

@mavam mavam added feature New functionality format Parser and printer labels Sep 13, 2023
@mavam mavam requested a review from jachris September 13, 2023 07:17
mavam
mavam commented Sep 13, 2023
View reviewed changes
dominiklohmann
dominiklohmann reviewed Sep 13, 2023
View reviewed changes
dominiklohmann
dominiklohmann reviewed Sep 13, 2023
View reviewed changes
@mavam mavam requested review from dominiklohmann and removed request for jachris September 13, 2023 07:24
dominiklohmann
dominiklohmann approved these changes Sep 13, 2023
View reviewed changes
Copy link
Member

@dominiklohmann dominiklohmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving modulo the already open comments.

jachris
jachris reviewed Sep 13, 2023
View reviewed changes
Copy link
Contributor

@jachris jachris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can see that this can be quite useful to have!

jachris
jachris reviewed Sep 13, 2023
View reviewed changes
@mavam mavam enabled auto-merge September 13, 2023 08:31
@mavam mavam merged commit 6200442 into main Sep 13, 2023
@mavam mavam deleted the topic/lines branch September 13, 2023 10:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dominiklohmann dominiklohmann dominiklohmann approved these changes

@jachris jachris jachris left review comments

Assignees
No one assigned
Labels
feature New functionality format Parser and printer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mavam @dominiklohmann @jachris