Skip to content

Support show nics to see network interfaces #3517

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Sep 18, 2023
Merged

Support show nics to see network interfaces #3517

merged 5 commits into from
Sep 18, 2023

Conversation

mavam
Copy link
Member

@mavam mavam commented Sep 15, 2023 •
edited
Loading

This PR makes show nics possible by turning the nic plugin into an aspect plugin.

@mavam mavam added operator Source, transformation, and sink improvement An incremental enhancement of an existing feature labels Sep 15, 2023
@mavam mavam marked this pull request as ready for review September 15, 2023 18:47
@mavam mavam enabled auto-merge September 16, 2023 10:21
dominiklohmann
dominiklohmann approved these changes Sep 18, 2023
View reviewed changes
Copy link
Member

@dominiklohmann dominiklohmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can confirm this works both locally on macOS and via Docker.

NB: Easiest way to test is this:

❯ docker run ghcr.io/tenzir/tenzir:topic-show-nics 'show nics'

The code looks good to me, it's a nice small addition.

@mavam mavam merged commit f2d4c96 into main Sep 18, 2023
@mavam mavam deleted the topic/show-nics branch September 18, 2023 08:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dominiklohmann dominiklohmann dominiklohmann approved these changes

Assignees
No one assigned
Labels
improvement An incremental enhancement of an existing feature operator Source, transformation, and sink
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mavam @dominiklohmann