Check for duplicate field names in zeek_tsv_parser #3578
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eliaskosunen
added
bug
jachris
approved these changes
Oct 16, 2023
eliaskosunen
force-pushed
the
topic/zeek-tsv-duplicate-fields
branch
from
709418d to
0d25dd5
Compare
jachris
reviewed
Oct 17, 2023
eliaskosunen
force-pushed
the
topic/zeek-tsv-duplicate-fields
branch
from
0d25dd5 to
4b5574c
Compare
eliaskosunen
force-pushed
the
topic/zeek-tsv-duplicate-fields
branch
from
4b5574c to
ee36ea7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes https://github.com/tenzir/issues/issues/933
We don't expect valid Zeek TSV data to ever contain duplicate field names, so if we encounter some, we can error with good conscience. Without this fix, there's a crash later on.