-
-
Notifications
You must be signed in to change notification settings - Fork 97
Add from/load/to/save <uri/file>
#3608
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
from <uri>
and from <file>
from <uri/file>
and load <file>
from <uri/file>
and load <file>
from <uri/file>
and load <uri/file>
af3ef1a
to
1e676b8
Compare
from <uri/file>
and load <uri/file>
from/load/to/save <uri/file>
1e676b8
to
10ab8cd
Compare
10ab8cd
to
a0f713a
Compare
864e87e
to
5912f12
Compare
5912f12
to
a1ebe94
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry that the review took so long. Had too many things to do, but it's very nice to get this feature finally!
4836a4c
to
a3cadae
Compare
a3cadae
to
26f42f1
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The improved UX is very nice! Thanks.
a166438
to
8b7e85c
Compare
56cc3b8
to
370da62
Compare
370da62
to
6483331
Compare
Unless there are any remaining issues, I think we can merge this 🚀 |
I think we can merge this, yes. |
Supersedes #3500, related to https://github.com/tenzir/issues/issues/328
In this PR:
OP <uri>
is mapped toOP <uri-scheme> <rest-of-uri>
, whereOP
is one of(from, load, to, save)
, and<uri>
is a RFC 3986 -compliant URI.OP <something-else>
is mapped toOP file <something-else>
if<something-else>
isn't a possible plugin name (doesn't conform to the pattern[A-Za-z0-9-_]*
)This effectively means, that the following mappings are implemented:
from https://example.com/foo
->from https example.com/foo
from gs://foo/bar
->from gcs gs://foo/bar
from file:///tmp/file
->from file /tmp/file
from /tmp/file
->from file /tmp/file
from ./local-file
->from file ./local-file
from local-file
-> error (no loaderlocal-file
found)from https
-> error (no URL given tohttps
loader)The logic implemented in this PR is as follows:

This current implementation accepts
from https:foo.bar/baz
asfrom https foo.bar/baz
. It's strictly not RFC 3986 -compliant, but I don't think it's that big of an issue.from <uri> [options...] [read <parser>]
from <path>
forfrom file <path>
load
to
andsave
gcs
)