Skip to content

Always enable time and bool synopses #3639

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 15, 2023

Conversation

dominiklohmann
Copy link
Member

This changes the catalog to always build time and bool synopses. These are really compact, so there is no downside to having them always enabled.

@dominiklohmann dominiklohmann added performance Improvements or regressions of performance improvement An incremental enhancement of an existing feature labels Nov 14, 2023
@dominiklohmann dominiklohmann requested a review from tobim November 14, 2023 13:46
This changes the catalog to always build time and bool synopses. These
are really compact, so there is no downside to having them always
enabled.
@dominiklohmann dominiklohmann force-pushed the topic/build-time-and-bool-synopses-by-default branch from 7d0ccac to b2787bf Compare November 14, 2023 13:47
@mavam
Copy link
Member

mavam commented Nov 14, 2023

What about a min-max sketch for durations?

@dominiklohmann
Copy link
Member Author

What about a min-max sketch for durations?

We don't have that in the code base right now and it's not in scope for this PR. Adding that is a bit more work.

@mavam
Copy link
Member

mavam commented Nov 14, 2023

We don't have that in the code base right now and it's not in scope for this PR

I don't follow. If we have it for time, we necessarily have it for duration because time is just a duration with an epoch.

@tobim
Copy link
Member

tobim commented Nov 14, 2023

I don't think we should get side-tracked here. This PR fixes a regression and we need to get that done and probably cut a patch release afterwards.
Adding a synopsis for durations is not impactful enough to warrant a delay here.

@dominiklohmann
Copy link
Member Author

@mavam I opened #3641 to implement that separately. It's hard to test right now, and while I've empirically verified it I'm not sure we should rely on the old synopsis infrastructure too much. Its serialization is a mysterious blackbox. It seems to work from some basic tests, but we should test that PR carefully in larger setup to verify its backwards compatibility.

@dominiklohmann dominiklohmann requested a review from mavam November 15, 2023 10:08
@dominiklohmann dominiklohmann merged commit 3f6e8ca into main Nov 15, 2023
@dominiklohmann dominiklohmann deleted the topic/build-time-and-bool-synopses-by-default branch November 15, 2023 10:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
improvement An incremental enhancement of an existing feature performance Improvements or regressions of performance
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants