Consider discard, export, and import as internal operators #3658
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dominiklohmann
added
engine
dominiklohmann
force-pushed
the
topic/ingress-egress-redef
branch
from
61d3933 to
b555462
Compare
We do not want to count egress or ingress for discard, export, and import. This makes it so their metrics are specifically annotated to be internal, as they are technically not ingress or egress.
dominiklohmann
force-pushed
the
topic/ingress-egress-redef
branch
from
b555462 to
1eb7d20
Compare
jachris
approved these changes
Nov 21, 2023
dominiklohmann
force-pushed
the
topic/ingress-egress-redef
branch
from
62e8adf to
b4f05bc
Compare
dominiklohmann
force-pushed
the
topic/ingress-egress-redef
branch
from
b4f05bc to
c39d82e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We do not want to count egress or ingress for discard, export, and import. This makes it so their metrics are specifically annotated to be internal, as they are technically not ingress or egress.