Support comments in xsv parser #3681
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eliaskosunen
force-pushed
the
topic/xsv-comments
branch
from
bfd6de8 to
81d5ffc
Compare
eliaskosunen
added
format
eliaskosunen
force-pushed
the
topic/xsv-comments
branch
from
81d5ffc to
d790a53
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes https://github.com/tenzir/issues/issues/1021
Add a new flag to
xsv(incl.csv,tsvandssv):--allow-comments. When enabled, lines starting with the'#'character are skipped. Comments at any other point in a line but the beginning, and comments marked with characters other than'#'are not supported.To prevent a regression, this behavior is opt-in.