Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support lists and null values and empty strings in XSV parser #3687

Merged
merged 6 commits into from
Nov 30, 2023

Conversation

dominiklohmann
Copy link
Member

This change adapts the XSV parser (and by extension the CSV, TSV, and SSV) parsers to support the same options as their respective printers for lists, null values, and empty strings—neither of which were previously supported.

@dominiklohmann dominiklohmann added bug Incorrect behavior format Parser and printer improvement An incremental enhancement of an existing feature labels Nov 29, 2023
@dominiklohmann dominiklohmann force-pushed the topic/xsv-parser-options branch from ea2afff to 3681dcd Compare November 29, 2023 12:47
@dominiklohmann dominiklohmann requested review from mavam and jachris and removed request for mavam November 29, 2023 12:47
Copy link
Contributor

@jachris jachris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, this is a much-needed improvement 👍

This change adapts the XSV parser (and by extension the CSV, TSV, and
SSV) parsers to support the same options as their respective printers
for lists, null values, and empty strings—neither of which were
previously supported.
@dominiklohmann dominiklohmann force-pushed the topic/xsv-parser-options branch from 3681dcd to 7c19ab6 Compare November 29, 2023 17:39
@dominiklohmann dominiklohmann force-pushed the topic/xsv-parser-options branch from 895f4d8 to 3777b4b Compare November 30, 2023 00:40
@dominiklohmann dominiklohmann force-pushed the topic/xsv-parser-options branch from 5d705d6 to 1e07e9d Compare November 30, 2023 13:34
@dominiklohmann dominiklohmann merged commit b81b89c into main Nov 30, 2023
@dominiklohmann dominiklohmann deleted the topic/xsv-parser-options branch November 30, 2023 16:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Incorrect behavior format Parser and printer improvement An incremental enhancement of an existing feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants