Skip to content

Use systemd provided default paths if available #3714

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 6, 2023

Conversation

tobim
Copy link
Member

@tobim tobim commented Dec 6, 2023

We recently introduced a bug in the systemd unit that caused tenzir to discard the db-directory and cache-directory settings from tenzir.yaml config files.

The change here restores the precedence while making sure that the paths provided by systemd will be used as defaults in case they are not set otherwise.

@tobim tobim added the bug Incorrect behavior label Dec 6, 2023
@tobim tobim requested review from lava and dominiklohmann December 6, 2023 12:37
Copy link
Member

@lava lava left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should also adjust the documentation and/or example.yaml to mention the new fallbacks and add a changelog entry, but otherwise looks good to me.

@tobim tobim force-pushed the topic/fix-systemd-config-setup branch from fbc807a to 3fdf661 Compare December 6, 2023 13:09
@tobim
Copy link
Member Author

tobim commented Dec 6, 2023

Fixed LOG_DIRECTORY -> LOGS_DIRECTORY, updated tenzir.yaml.example and squashed.

@tobim tobim enabled auto-merge December 6, 2023 13:10
@tobim tobim merged commit ed362c9 into main Dec 6, 2023
@tobim tobim deleted the topic/fix-systemd-config-setup branch December 6, 2023 14:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Incorrect behavior
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants