Add time parser #3738
Merged
Add time parser #3738
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eliaskosunen
force-pushed
the
topic/time-parser
branch
5 times, most recently
from
ccc057e to
aac7549
Compare
eliaskosunen
force-pushed
the
topic/time-parser
branch
5 times, most recently
from
710bff1 to
1bbd25e
Compare
eliaskosunen
force-pushed
the
topic/time-parser
branch
2 times, most recently
from
ece7294 to
5b69904
Compare
dominiklohmann
previously approved these changes
Dec 21, 2023
eliaskosunen
force-pushed
the
topic/time-parser
branch
2 times, most recently
from
52e246e to
43a61c2
Compare
|
It seems like libc++ (the stdlib on macOS) |
eliaskosunen
force-pushed
the
topic/time-parser
branch
from
43a61c2 to
3a1637d
Compare
eliaskosunen
force-pushed
the
topic/time-parser
branch
7 times, most recently
from
9fda103 to
243977b
Compare
eliaskosunen
changed the base branch from
main
to
topic/diagnostic-for-unknown-msgpack-type
Dakostu
force-pushed
the
topic/diagnostic-for-unknown-msgpack-type
branch
2 times, most recently
from
9ac499f to
7b37d72
Compare
Base automatically changed from
topic/diagnostic-for-unknown-msgpack-type
to
main
January 11, 2024 07:40
eliaskosunen
force-pushed
the
topic/time-parser
branch
2 times, most recently
from
5484a32 to
ccc38d1
Compare
dominiklohmann
approved these changes
Jan 12, 2024
eliaskosunen
force-pushed
the
topic/time-parser
branch
from
ccc38d1 to
166e51a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes https://github.com/tenzir/issues/issues/1051
Adds a new parser,
time, based on POSIXstrptime.<format>is a format string compatible withstrptime. The output is atenzir::time, except if the--componentsflag is passed, the output is a record. There's some additional logic for missing fields and what their default values are, which can be controlled with--strict.Deals with timezones properly, which letmetellya is something one should not call trivial.