Skip to content

Allow empty field names #3742

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Dec 18, 2023
Merged

Allow empty field names #3742

merged 2 commits into from
Dec 18, 2023

Conversation

jachris
Copy link
Contributor

@jachris jachris commented Dec 15, 2023

Previously, the record {"": 42} was not allowed. This PR removes this restriction.

@jachris jachris force-pushed the topic/allow-empty-field-names branch from 0f19ee2 to 9b6cb5f Compare December 15, 2023 12:54
@jachris jachris added the engine Core pipeline and storage engine label Dec 15, 2023
@jachris jachris marked this pull request as ready for review December 15, 2023 12:54
Copy link
Member

@dominiklohmann dominiklohmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@jachris jachris enabled auto-merge December 18, 2023 08:21
@jachris jachris force-pushed the topic/allow-empty-field-names branch from f529d4e to 1607baf Compare December 18, 2023 10:59
@dominiklohmann dominiklohmann merged commit 3510308 into main Dec 18, 2023
@dominiklohmann dominiklohmann deleted the topic/allow-empty-field-names branch December 18, 2023 17:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
engine Core pipeline and storage engine
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants