Improve handling of open file descriptors #3784
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lava
commented
Jan 9, 2024
lava
added
bug
mavam
reviewed
Jan 9, 2024
lava
force-pushed
the
topic/health-metrics
branch
2 times, most recently
from
92aa0d1 to
8311e2e
Compare
lava
force-pushed
the
topic/fd-ulimits
branch
from
4edfa00 to
fb62682
Compare
lava
force-pushed
the
topic/health-metrics
branch
from
8311e2e to
f4561ab
Compare
lava
force-pushed
the
topic/fd-ulimits
branch
6 times, most recently
from
e2bf523 to
9ad0b58
Compare
lava
force-pushed
the
topic/health-metrics
branch
from
4266b29 to
1b43460
Compare
lava
force-pushed
the
topic/fd-ulimits
branch
from
9ad0b58 to
09b07c5
Compare
mavam
approved these changes
Jan 12, 2024
lava
force-pushed
the
topic/health-metrics
branch
5 times, most recently
from
4074359 to
311a45c
Compare
Attempt to improve the behavior of nodes that are running
into the maximum number of open files:
* Increase the upper limit imposed by our systemd unit files
to 64Ki. We avoid going all the way to `LimitNOFILE=infinity`,
so that in the case of a file descriptor leak the node will
fail at some point rather than the system hitting the maximum
number of global open files.
* Add monitoring of open file descriptors as a health metric
so that leaks can be detected by looking at the rate of
change over time.
lava
force-pushed
the
topic/fd-ulimits
branch
from
09b07c5 to
82dd87b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Attempt to improve the behavior of nodes that are running into the maximum number of open files: