Display failing pipeline diagnostics in /serve
#3788
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dominiklohmann
added
bug
This changes `/serve` to show pipeline diagnostics when the pipeline is no longer available instead of a generic error. To make this possible I had to change the routing of down messages between execution nodes and the pipeline executor, and also very slightly change how diagnostics are emitted.
dominiklohmann
force-pushed
the
topic/serve-diagnostics
branch
from
f2c1461 to
b06a4e3
Compare
jachris
reviewed
Jan 10, 2024
jachris
reviewed
Jan 10, 2024
jachris
approved these changes
Jan 12, 2024
jachris
force-pushed
the
topic/serve-diagnostics
branch
from
88b86cd to
2ee6f2c
Compare
jachris
force-pushed
the
topic/serve-diagnostics
branch
from
2ee6f2c to
7647bfb
Compare
dominiklohmann
force-pushed
the
topic/serve-diagnostics
branch
from
9607134 to
cf93d39
Compare
dominiklohmann
force-pushed
the
topic/serve-diagnostics
branch
from
6402581 to
b05d0a4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes tenzir/issues#1099
This changes
/serveto show pipeline diagnostics when the pipeline is no longer available instead of a generic error. To make this possible I had to change the routing of down messages between execution nodes and the pipeline executor, and also very slightly change how diagnostics are emitted.