Skip to content

Add structured_data to syslog output #3871

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 31, 2024
Merged

Conversation

eliaskosunen
Copy link
Contributor

Closes https://github.com/tenzir/issues/issues/1072

Previously, the structured_data field in new-RFC syslog messages was parsed, but wasn't included in the output. This was chiefly because the data was in a tenzir::map, which our data model doesn't support well. This PR changes it to be a list of key-value-pair-records, that are included in the output.

@eliaskosunen eliaskosunen added format Parser and printer improvement An incremental enhancement of an existing feature labels Jan 26, 2024
@eliaskosunen eliaskosunen force-pushed the topic/syslog-structured-data branch 2 times, most recently from 69f2a0e to 82a5287 Compare January 29, 2024 08:32
@eliaskosunen eliaskosunen force-pushed the topic/syslog-structured-data branch from 82a5287 to a8e4a20 Compare January 30, 2024 11:32
@eliaskosunen eliaskosunen marked this pull request as ready for review January 30, 2024 11:33
Copy link
Member

@dominiklohmann dominiklohmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a really straightforward change. Just one small request for the docs.

@eliaskosunen eliaskosunen merged commit 0999e1f into main Jan 31, 2024
@eliaskosunen eliaskosunen deleted the topic/syslog-structured-data branch January 31, 2024 14:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
format Parser and printer improvement An incremental enhancement of an existing feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants