Make python operator not discard fields that start with an underscore
#4085
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jachris
added
operator
jachris
force-pushed
the
topic/python-operator-underscore
branch
from
1ae3883 to
522cca9
Compare
dominiklohmann
approved these changes
Apr 4, 2024
jachris
force-pushed
the
topic/python-operator-underscore
branch
from
522cca9 to
6e6ad2a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fields starting with
_were previously discarded due to some implementation details. However, following #4036, this is no longer necessary. I also used this opportunity to clean up the surrounding code.