Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Python module for submitting queries to VAST #685

Merged
merged 23 commits into from
Jan 27, 2020
Merged

Add Python module for submitting queries to VAST #685

merged 23 commits into from
Jan 27, 2020

Conversation

tobim
Copy link
Member

@tobim tobim commented Dec 11, 2019

No description provided.

@tobim tobim added the feature New functionality label Dec 11, 2019
@lgtm-com
Copy link

lgtm-com bot commented Dec 11, 2019

This pull request introduces 1 alert when merging 4e1190b into 4c5ee09 - view on LGTM.com

new alerts:

  • 1 for Unused import

mavam
mavam requested changes Dec 11, 2019
View reviewed changes
@lgtm-com
Copy link

lgtm-com bot commented Jan 13, 2020

This pull request introduces 2 alerts when merging d39b02a into 14e1e6e - view on LGTM.com

new alerts:

  • 1 for Unused import
  • 1 for 'import *' may pollute namespace

@lgtm-com
Copy link

lgtm-com bot commented Jan 14, 2020

This pull request introduces 1 alert when merging c87beca into 8c0f8de - view on LGTM.com

new alerts:

  • 1 for 'import *' may pollute namespace

@lgtm-com
Copy link

lgtm-com bot commented Jan 17, 2020

This pull request introduces 1 alert when merging 55b2d13 into e6bc926 - view on LGTM.com

new alerts:

  • 1 for 'import *' may pollute namespace

@lgtm-com
Copy link

lgtm-com bot commented Jan 17, 2020

This pull request introduces 1 alert when merging 70ea0cd into e6bc926 - view on LGTM.com

new alerts:

  • 1 for 'import *' may pollute namespace

@lgtm-com
Copy link

lgtm-com bot commented Jan 17, 2020

This pull request introduces 1 alert when merging 72e12e7 into e6bc926 - view on LGTM.com

new alerts:

  • 1 for 'import *' may pollute namespace

@mavam mavam changed the title Add a python module for submitting queries to vast Add Python module for submitting queries to VAST Jan 18, 2020
@lgtm-com
Copy link

lgtm-com bot commented Jan 21, 2020

This pull request introduces 1 alert when merging e448a85 into 2ee2ca6 - view on LGTM.com

new alerts:

  • 1 for 'import *' may pollute namespace

@lgtm-com
Copy link

lgtm-com bot commented Jan 21, 2020

This pull request introduces 1 alert when merging 3f36719 into 2ee2ca6 - view on LGTM.com

new alerts:

  • 1 for 'import *' may pollute namespace

@lgtm-com
Copy link

lgtm-com bot commented Jan 21, 2020

This pull request introduces 1 alert when merging cd701f3 into 2ee2ca6 - view on LGTM.com

new alerts:

  • 1 for 'import *' may pollute namespace

@lgtm-com
Copy link

lgtm-com bot commented Jan 21, 2020

This pull request introduces 1 alert when merging 9b25021 into 2ee2ca6 - view on LGTM.com

new alerts:

  • 1 for 'import *' may pollute namespace

@tobim tobim force-pushed the story/ch10558 branch 2 times, most recently from 7d1489c to fb21daa Compare January 22, 2020 14:18
@lgtm-com
Copy link

lgtm-com bot commented Jan 22, 2020

This pull request introduces 1 alert when merging fb21daa into baa81bc - view on LGTM.com

new alerts:

  • 1 for 'import *' may pollute namespace

@tobim tobim marked this pull request as ready for review January 22, 2020 15:53
mavam
mavam requested changes Jan 22, 2020
View reviewed changes
Copy link
Member

@mavam mavam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good work. I have only wordsmithing comments.

@mavam
Copy link
Member

mavam commented Jan 22, 2020

Can you also address the LGTM comment?

@mavam
Copy link
Member

mavam commented Jan 22, 2020

And finally, please add one or more changelog entries.

@lgtm-com
Copy link

lgtm-com bot commented Jan 22, 2020

This pull request introduces 1 alert when merging 982268e into baa81bc - view on LGTM.com

new alerts:

  • 1 for 'import *' may pollute namespace

dominiklohmann
dominiklohmann reviewed Jan 24, 2020
View reviewed changes
examples/ipython/demo.md

```sh
#brew install jupyter numpy matplotlib pandas apache-arrow networkx
python3 -mpip install matplotlib numpy pyarrow pandas networkx
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
python3 -mpip install matplotlib numpy pyarrow pandas networkx
python3 -m pip install matplotlib numpy pyarrow pandas networkx

@tobim tobim force-pushed the story/ch10558 branch 2 times, most recently from f81b698 to ea8459c Compare January 24, 2020 09:18
tobim and others added 22 commits January 24, 2020 10:19
@tobim
Blacklist iPython files for Black
267c84d
@tobim
Add a python module for submitting queries to vast
258d99b
@tobim
Allow quoted strings in record field names
f61f8c4 
This relaxes the schema language to allow for more flexibility
when naming record fields with the syntax:
```
record{
  "#this is an example $": bool
}
```
This is required because several input formats work in a similar
fashion, and our generic format parsers depend on schema field
names and data field names to be indentical.
@tobim
Use CHECK_EQUAL in the string unit tests
920db10
@tobim
Test double escaping cases in quoted string parser
8982af1
@tobim
Add a double escape case to the json_unescape test
eae9a91
@tobim
Fix double escaping in the quoted string parser
25fc254
@tobim
Be more resilient towards malformed JSON input
b168e69 
The JSON reader used to abort if the JSON parser was not able to
produce an object. This commit changes the behavior to log a
warning message and continue to the next line.
@tobim
Prefer line break at assignment over operation
a71c616
@tobim
Add a notebook to showcase a simple graph analysis
a73566b
@tobim
Update vast connections notebook
2125451
@tobim
Add a script for a small demo
843dd6a
@mavam @tobim
Tweak demo script
2f7fd37
@tobim
Add changelog entries for the parser changes
ca3aeba
@tobim
Pin the arrow demo to a known good nixpkgs version
c3fbdd0
@tobim @mavam
Capitalize the word Suricata
bb28b07 
Co-Authored-By: Matthias Vallentin <matthias@tenzir.com>
@tobim
Clarify the Instructions for starting the Notebook
f6521c3
@tobim @mavam
Print the input data when JSON parsing failed
025b682 
Co-Authored-By: Matthias Vallentin <matthias@tenzir.com>
@tobim @mavam
Rename try_connect to connect
deb6954 
Co-Authored-By: Matthias Vallentin <matthias@tenzir.com>
@tobim
Add changelog entry for pyvast
e58147c
@tobim
Augment changelog messages with PR links
d97f342
@tobim
Move iPython demo into examples
1a0b8a4
@mavam mavam merged commit 1c09d6a into master Jan 27, 2020
@mavam mavam deleted the story/ch10558 branch January 27, 2020 10:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dominiklohmann dominiklohmann dominiklohmann left review comments

@mavam mavam mavam approved these changes

Assignees
No one assigned
Labels
feature New functionality
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tobim @mavam @dominiklohmann