Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove default option for historical queries #754

Merged
merged 2 commits into from
Feb 11, 2020
Merged

Remove default option for historical queries #754

merged 2 commits into from
Feb 11, 2020

Conversation

dominiklohmann
Copy link
Member

@dominiklohmann dominiklohmann commented Feb 11, 2020

This PR removes the --historical flag, since it's just the default and doesn't actually change anything.

@dominiklohmann dominiklohmann added the bug Incorrect behavior label Feb 11, 2020
@dominiklohmann dominiklohmann requested a review from a team February 11, 2020 14:31
This commit removes the `--historical` flag, since it's just the default
and doesn't actually change anything.
@dominiklohmann dominiklohmann changed the title Rename ambigiuous short option for --historical Remove default option for historical queries Feb 11, 2020
Copy link
Member

@mavam mavam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mind adding a changelog entry?

@dominiklohmann dominiklohmann requested a review from mavam February 11, 2020 15:08
@mavam mavam merged commit f31eaed into master Feb 11, 2020
@mavam mavam deleted the story/ch12332 branch February 11, 2020 15:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Incorrect behavior
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants