Skip to content

Fix user shutdown handling for continuous exports #779

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 4, 2020
Merged

Fix user shutdown handling for continuous exports #779

merged 1 commit into from
Mar 4, 2020

Conversation

dominiklohmann
Copy link
Member

Before this change, stopping a continuous export process with ctrl + c produced this error message:

exporter got error during streaming:  none

@dominiklohmann dominiklohmann added the bug Incorrect behavior label Mar 4, 2020
@dominiklohmann dominiklohmann requested a review from a team March 4, 2020 09:34
@dominiklohmann dominiklohmann marked this pull request as ready for review March 4, 2020 09:38
@dominiklohmann dominiklohmann merged commit db86a7a into master Mar 4, 2020
@dominiklohmann dominiklohmann deleted the story/ch13518 branch March 4, 2020 12:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tobim tobim tobim approved these changes

Assignees
No one assigned
Labels
bug Incorrect behavior
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dominiklohmann @tobim