Skip to content

Make archive session extraction interruptible #825

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Apr 9, 2020
Merged

Conversation

dominiklohmann
Copy link
Member

@dominiklohmann dominiklohmann commented Apr 8, 2020

No description provided.

@dominiklohmann dominiklohmann added the bug Incorrect behavior label Apr 8, 2020
@dominiklohmann dominiklohmann force-pushed the story/ch14551 branch 2 times, most recently from 08dd21b to c79f6fa Compare April 8, 2020 14:16
@dominiklohmann dominiklohmann marked this pull request as ready for review April 8, 2020 14:16
@dominiklohmann dominiklohmann requested a review from mavam April 8, 2020 14:23
@dominiklohmann dominiklohmann force-pushed the story/ch14551 branch 2 times, most recently from 86a3038 to 1d9d658 Compare April 8, 2020 17:20
mavam
mavam previously approved these changes Apr 8, 2020
@dominiklohmann dominiklohmann dismissed mavam’s stale review April 9, 2020 07:29

It's currently broken and requires some architectural changes, so I've dismissed the review.

@dominiklohmann
Copy link
Member Author

Pivot is working now, please review again @mavam.

@dominiklohmann dominiklohmann requested a review from mavam April 9, 2020 12:27
dominiklohmann and others added 2 commits April 9, 2020 16:51
This ensures portability; message handlers should always have explicit
integer widths.
Copy link
Member

@mavam mavam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work!

@dominiklohmann dominiklohmann merged commit 48f6f2b into master Apr 9, 2020
@dominiklohmann dominiklohmann deleted the story/ch14551 branch April 9, 2020 16:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Incorrect behavior
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants