Skip to content

Fix meta index nondeterminism #842

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Apr 24, 2020
Merged

Fix meta index nondeterminism #842

merged 5 commits into from
Apr 24, 2020

Conversation

tobim
Copy link
Member

@tobim tobim commented Apr 23, 2020

No description provided.

@tobim tobim added the bug Incorrect behavior label Apr 23, 2020
@tobim tobim requested a review from a team April 23, 2020 22:34
mavam added 3 commits April 24, 2020 06:28
By pushing down the sort operations to intermediate results, we get
better cache utilization because we perform scans on smaller memory
blocks.
Copy link
Member

@dominiklohmann dominiklohmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can confirm this fixed the issue on my end. Just some minor suggestions.

Co-Authored-By: Dominik Lohmann <mail@dominiklohmann.de>
@mavam
Copy link
Member

mavam commented Apr 24, 2020

Thanks for the logging improvements!

@mavam mavam merged commit b21a426 into master Apr 24, 2020
@mavam mavam deleted the story/ch15201 branch April 24, 2020 08:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Incorrect behavior
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants