Various config and default setting fixes #866
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This inverts the logic to suppress the to file logging of client commands. The old algorithm overwrites the verbosity setting with the default value after it was parsed, if the command is either `vast start` or `vast -N ...`. This means that user specified levels from the config file or the command line would have no effect. The new method does the opposite: Once we know the command does not start a node the file logging is turned off.
lava
requested changes
May 12, 2020
| @@ -306,19 +306,22 @@ logger { | |||
|
|
|||
| ; Configures the minimum severity of messages written to the log file. | |||
| ; Possible values: quiet, error, warning, info, verbose, debug, trace. | |||
| ;file-verbosity = "debug" | |||
| ; File logging is only available for commands that start a node (e.g., | |||
| ; vast start). The levels above 'verbose' are usually not available in | |||
There was a problem hiding this comment.
Not sure, but intuitively I'd say s/above/below/?
There was a problem hiding this comment.
info -> low verbosity; debug -> high verbosity?
There was a problem hiding this comment.
Sure, but info -> higher importance, debug -> lower importance.
But I'll let you decide, this was only a side comment.
lava
approved these changes
May 12, 2020
|
Sorry for the late addition, please check if the last commit is to your liking. |
dominiklohmann
approved these changes
May 12, 2020
|
I just pushed once more to fix the broken formatting in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.