Skip to content

Publish Sysmon schema #886

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
May 27, 2020
Merged

Publish Sysmon schema #886

merged 7 commits into from
May 27, 2020

Conversation

dominiklohmann
Copy link
Member

@tenzir/backend side note: I've also taken a few minutes to fix some warnings I've encountered and just put them in here. The only warnings left with clang are deprecation warnings for Arrow 0.17 now.

@dominiklohmann dominiklohmann requested a review from a team May 27, 2020 12:04
Copy link
Member

@lava lava left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good modulo the comments on the flat_map/stable_map change.

@dominiklohmann dominiklohmann force-pushed the story/ch17070 branch 2 times, most recently from c661336 to dc7219d Compare May 27, 2020 12:29
Unlike stable_map::find, flat_map::find appears to be slightly broken
and sometimes fails to return the desired result.
@lava noticed this one after code review.
@dominiklohmann dominiklohmann merged commit d610fcc into master May 27, 2020
@dominiklohmann dominiklohmann deleted the story/ch17070 branch May 27, 2020 13:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants