Skip to content

Print timestamps with full precision for JSON #909

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jun 9, 2020
Merged

Print timestamps with full precision for JSON #909

merged 2 commits into from
Jun 9, 2020

Conversation

dominiklohmann
Copy link
Member

No description provided.

@dominiklohmann dominiklohmann added the bug Incorrect behavior label Jun 9, 2020
@dominiklohmann dominiklohmann requested a review from a team June 9, 2020 09:25
mavam
mavam requested changes Jun 9, 2020
View reviewed changes
Copy link
Member

@mavam mavam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd like to see some sort of test that captures this change. Could be as simple as exporting a time value as JSON in an integration test.

@dominiklohmann dominiklohmann requested a review from mavam June 9, 2020 15:33
@dominiklohmann
Copy link
Member Author

I'd like to see some sort of test that captures this change.

I just forgot to update the tests, they failed in CI. They're now fixed.

@dominiklohmann
Copy link
Member Author

I rebased to fix the merge conflict in the changelog.

@dominiklohmann dominiklohmann merged commit 4f5bb18 into master Jun 9, 2020
@dominiklohmann dominiklohmann deleted the story/ch17395 branch June 9, 2020 20:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mavam mavam mavam approved these changes

Assignees
No one assigned
Labels
bug Incorrect behavior
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dominiklohmann @mavam