Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a get subcommand to retrieve events from the archive directly #938

Merged
merged 16 commits into from
Sep 24, 2020
Merged

Add a get subcommand to retrieve events from the archive directly #938

merged 16 commits into from
Sep 24, 2020

Conversation

tobim
Copy link
Member

@tobim tobim commented Jun 19, 2020 •
edited
Loading

Please note that we do not necessarily need to merge this, it is just a tool to simplify the investigation of latency issues of vast export. The actual fix will come in a different PR after the issue is identified.

@tobim tobim added feature New functionality enhancement ✨ labels Jun 19, 2020
dominiklohmann
dominiklohmann reviewed Jun 23, 2020
View reviewed changes
@tobim tobim force-pushed the story/ch17108/get-command branch from b03696d to 796330b Compare August 30, 2020 19:30
@tobim tobim marked this pull request as ready for review September 1, 2020 20:43
@tobim tobim force-pushed the story/ch17108/get-command branch from 796330b to 89830d1 Compare September 1, 2020 20:52
@tobim tobim force-pushed the story/ch17108/get-command branch 2 times, most recently from 4ff55ad to 2cbf312 Compare September 23, 2020 09:24
@tobim tobim force-pushed the story/ch17108/get-command branch 2 times, most recently from 2a04081 to a6ee430 Compare September 23, 2020 14:45
dominiklohmann
dominiklohmann requested changes Sep 23, 2020
View reviewed changes
Copy link
Member

@dominiklohmann dominiklohmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is mostly looking fine, I just have minor stuff:

  • zeek-to-vast seems to be missing an include (that used to be available transitively).
  • please add to vast.yaml.example, rebase onto master, and use vast.get.format over get.format.

dominiklohmann
dominiklohmann requested changes Sep 24, 2020
View reviewed changes
Copy link
Member

@dominiklohmann dominiklohmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've got a bunch of small requests.

Tested this locally and it works as expected.

@tobim tobim force-pushed the story/ch17108/get-command branch from 3ed882c to d678599 Compare September 24, 2020 10:21
dominiklohmann
dominiklohmann approved these changes Sep 24, 2020
View reviewed changes
Copy link
Member

@dominiklohmann dominiklohmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving, but please improve the changelog entry.

@tobim tobim merged commit 75a2e9c into master Sep 24, 2020
@tobim tobim deleted the story/ch17108/get-command branch September 24, 2020 11:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dominiklohmann dominiklohmann dominiklohmann approved these changes

Assignees
No one assigned
Labels
feature New functionality
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tobim @dominiklohmann