Skip to content

Rename the 'default' table slice type to 'caf' #948

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 24, 2020
Merged

Conversation

dominiklohmann
Copy link
Member

The 'default' table slice type has not been the default for a while now when Apache Arrow is available. The name 'caf' more accurately describes what it does.

@dominiklohmann dominiklohmann requested a review from a team June 24, 2020 08:22
The 'default' table slice type has not been the default for a while now
when Apache Arrow is available. The name 'caf' more accurately describes
what it does.
@dominiklohmann
Copy link
Member Author

I have verified this to work locally using ./configure --without-arrow.

Copy link
Member

@tobim tobim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you change one of the integration tests to explicitly use --table-slice-type="caf"?

@dominiklohmann dominiklohmann requested a review from tobim June 24, 2020 09:15
@dominiklohmann dominiklohmann merged commit d4c3221 into master Jun 24, 2020
@dominiklohmann dominiklohmann deleted the story/ch14497 branch June 24, 2020 11:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants