Skip to content

Restructure vast status #995

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 26 commits into from
Sep 2, 2020
Merged

Restructure vast status #995

merged 26 commits into from
Sep 2, 2020

Conversation

tobim
Copy link
Member

@tobim tobim commented Jul 29, 2020

No description provided.

@tobim tobim added maintenance Tasks for keeping up the infrastructure enhancement ✨ labels Jul 29, 2020
@tobim tobim force-pushed the story/ch17222/restructure-status branch 4 times, most recently from 41f154a to e362055 Compare August 19, 2020 14:54
@tobim tobim force-pushed the story/ch17222/restructure-status branch 4 times, most recently from bd48107 to 710245d Compare August 20, 2020 07:16
@tobim tobim marked this pull request as ready for review August 20, 2020 07:17
@tobim tobim force-pushed the story/ch17222/restructure-status branch 2 times, most recently from 69f2da4 to a5a0928 Compare August 20, 2020 08:40
Copy link
Member

@dominiklohmann dominiklohmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

First review round; this time code only. Still compiling on the side to give feedback to the output itself.

Copy link
Member

@dominiklohmann dominiklohmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

From a user POV, I've noticed a few things:

Things are no longer grouped by components. The output is much easier to parse if the info, verbose and debug objects are merged like this:

vast status -v debug | jq '.info * .debug * .verbose'

I think we should just do this by default. Having .info.archive and .debug.archive separated from each other makes no sense as a user.

For the components, the names are doubled as keys. In a future PR, I'd like to see a components: [...] array containing all the components, with components[<index>].name containing the name. Right now, <name>.name is always "<name>".

The helptext of vast status should show what unit the memory usage values are in.

@tobim tobim force-pushed the story/ch17222/restructure-status branch from a5a0928 to 1233c7e Compare August 30, 2020 20:15
@tobim tobim force-pushed the story/ch17222/restructure-status branch 2 times, most recently from e335396 to 0c241d8 Compare September 1, 2020 15:51
@tobim tobim force-pushed the story/ch17222/restructure-status branch 2 times, most recently from 21a8d40 to 1872693 Compare September 1, 2020 19:59
@tobim tobim force-pushed the story/ch17222/restructure-status branch from 1872693 to f98f91e Compare September 1, 2020 20:45
Copy link
Member

@dominiklohmann dominiklohmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you clean up the includes and the guarding #ifs in libvast/src/detail/process.cpp? There are some seemingly unnecessary includes, and they should be moved to the top.

We also shouldn't use both __linux__ and VAST_LINUX, only the latter should be used for guarding includes.

@tobim tobim force-pushed the story/ch17222/restructure-status branch from 03cea48 to 3fdc413 Compare September 2, 2020 15:17
Copy link
Member

@dominiklohmann dominiklohmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! 🙏

I verified locally that this looks as we discussed.

@tobim tobim merged commit 2668a79 into master Sep 2, 2020
@tobim tobim deleted the story/ch17222/restructure-status branch September 2, 2020 20:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintenance Tasks for keeping up the infrastructure
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants