Remove Version FlatBuffers table #1168
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was essentially useless now; since we're breaking with the new `table_slice` API anyways, we might as well remove this altogether now.
dominiklohmann
force-pushed
the
topic/remove-version-flatbuffer
branch
from
1caffab
to
f1c635c
Compare
Base automatically changed from
epic/flatbuffers-persistence-table-slices
to
master
November 16, 2020 07:28
tobim
approved these changes
Nov 16, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📔 Description
version.fbswas essentially useless now; since we're breaking with the newtable_sliceAPI anyways, we might as well remove this altogether now.Note: This change is based on #1140, but can be reviewed and merged independently of it. This just removes the inevitable merge conflict that we'd need to resolve.
📝 Checklist
🎯 Review Instructions
n/t