Fix crash in query evaluation for new partitions #2295
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes a rather annoying timing bug: We create new active partitions on demand, and immediately feed them events. If, however, a query arrives it may be scheduled before any of the events were added to the active partition, leading to it not having any indexers, which in turn leads to it not having a combined layout. The query evaluation wrongly assumed that every partition always had a combined layout, which caused a crash.
dominiklohmann
force-pushed
the
story/sc-34111/active-partition-crash
branch
from
a96a9a1
to
c770183
Compare
|
I'll test this by adding a |
tobim
approved these changes
May 23, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes a rather annoying timing bug: We create new active partitions on demand, and immediately feed them events. If, however, a query arrives it may be scheduled before any of the events were added to the active partition, leading to it not having any indexers, which in turn leads to it not having a combined layout. The query evaluation wrongly assumed that every partition always had a combined layout, which caused a crash.
馃摑 Checklist
馃幆 Review Instructions
Follow the changed logic and verify that this was indeed an issue.