Add "-total" metric keys for schema-dependent metrics #2682
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Dakostu
force-pushed
the
story/sc-38886
branch
from
ea3c851
to
d52dee3
Compare
patszt
reviewed
Nov 4, 2022
patszt
reviewed
Nov 4, 2022
patszt
suggested changes
Nov 4, 2022
Dakostu
force-pushed
the
story/sc-38886
branch
from
8bd1d54
to
c08da77
Compare
patszt
approved these changes
Nov 4, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds three metric keys
catalog.num-partitions-total,catalog.num-events-totalandingest-totalthat sum up all schema-based metrics by their respective schema-based metric counterparts.馃摑 Reviewer Checklist
Review this pull request by ensuring the following items: