Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement generic Community ID computation API #525

Merged
merged 15 commits into from Jul 11, 2019

Conversation

@mavam
Copy link
Member

commented Jul 1, 2019

This PR adds a the Community ID to PCAP packet data.

@mavam mavam added the feature 🎁 label Jul 1, 2019

@mavam mavam changed the title Add Community ID to PCAP packet data Implement generic Community ID computation API Jul 11, 2019

@mavam mavam marked this pull request as ready for review Jul 11, 2019

@Neverlord
Copy link
Collaborator

left a comment

Looks good! Just a couple of minor suggestions.

libvast/test/community_id.cpp Outdated Show resolved Hide resolved
libvast/vast/community_id.hpp Outdated Show resolved Hide resolved
libvast/vast/community_id.hpp Outdated Show resolved Hide resolved
libvast/vast/community_id.hpp Outdated Show resolved Hide resolved
libvast/vast/community_id.hpp Show resolved Hide resolved
libvast/vast/detail/coding.hpp Outdated Show resolved Hide resolved
libvast/vast/icmp.hpp Outdated Show resolved Hide resolved
libvast/vast/icmp.hpp Outdated Show resolved Hide resolved
libvast/vast/icmp.hpp Outdated Show resolved Hide resolved
libvast/test/hash.cpp Outdated Show resolved Hide resolved

@mavam mavam force-pushed the story/ch6424 branch from f000a45 to 4e36764 Jul 11, 2019

libvast/vast/format/mrt.hpp Outdated Show resolved Hide resolved

@mavam mavam merged commit e52e56b into master Jul 11, 2019

5 checks passed

continuous-integration/jenkins/branch This commit looks good
Details
coverage Generated coverage report
Details
integration All 11 integration tests passed
Details
style This patch follows our style conventions
Details
tests All 6 builds passed the unit tests
Details

@mavam mavam deleted the story/ch6424 branch Jul 11, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
You can’t perform that action at this time.