Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable Cirrus CI #564

Merged
merged 8 commits into from Sep 3, 2019
Merged

Enable Cirrus CI #564

merged 8 commits into from Sep 3, 2019

Conversation

tobim
Copy link
Member

@tobim tobim commented Aug 28, 2019

  • Add macOS build
  • Prettify names

@tobim tobim added the feature New functionality label Aug 28, 2019
@tobim tobim closed this Aug 29, 2019
@tobim tobim deleted the story/ch8191 branch August 29, 2019 12:05
@tobim tobim restored the story/ch8191 branch August 29, 2019 12:05
@tobim tobim reopened this Aug 29, 2019
@tobim tobim force-pushed the story/ch8191 branch 7 times, most recently from a154f1c to c78e8c2 Compare August 29, 2019 13:59
@mavam mavam changed the title Enable cirrus ci Enable Cirrus CI Aug 29, 2019
@tobim tobim force-pushed the story/ch8191 branch 7 times, most recently from 52e50ec to 50e1482 Compare August 30, 2019 14:03
@mavam
Copy link
Member

mavam commented Aug 30, 2019

The style check seems to fail despite the checkmark:

git diff -U0 --no-color $(git merge-base origin/master HEAD) | scripts/clang-format-diff.py -p1;
fatal: Not a valid object name origin/master

.cirrus.yml Outdated Show resolved Hide resolved
@tobim tobim force-pushed the story/ch8191 branch 6 times, most recently from 04aaa2b to 21e6f5c Compare September 2, 2019 14:55
@tobim tobim marked this pull request as ready for review September 3, 2019 09:15
@tobim
Copy link
Member Author

tobim commented Sep 3, 2019

The style check seems to fail despite the checkmark:

git diff -U0 --no-color $(git merge-base origin/master HEAD) | scripts/clang-format-diff.py -p1;
fatal: Not a valid object name origin/master

Thanks for pointing that out, it is fixed now.

@tobim
Copy link
Member Author

tobim commented Sep 3, 2019

To get really nice names we'd have to stop using the matrix feature, because the option alternatives are always added to the name field. This would not be extremely painful, because of the yaml anchor feature, but still a bit more repetitive than what we have now.
As for X_task overriding the name key: This is a known cirrus bug and will sort itself out.

In all, I consider this PR complete.

Copy link
Member

@mavam mavam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work!

@mavam mavam merged commit 0ee467f into master Sep 3, 2019
@mavam mavam deleted the story/ch8191 branch September 3, 2019 12:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New functionality
Projects
None yet
2 participants