Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change default listen address to 'localhost' #828

Merged
merged 1 commit into from Apr 15, 2020

Conversation

lava
Copy link
Member

@lava lava commented Apr 15, 2020

We dont want to expose vast to the network without the user explicitly setting it up that way.

@dominiklohmann
Copy link
Member

Can you add a changelog entry?

@lava lava force-pushed the topic/default-listen-address branch from 07a3a2f to 3416052 Compare April 15, 2020 10:12
CHANGELOG.md Show resolved Hide resolved
VAST_INFO_ANON("VAST node is listening on", (host ? host : "")
<< ':' << *bound_port);
auto listen_addr = std::string{host} + ':' + std::to_string(*bound_port);
VAST_INFO_ANON("VAST node is listening on", listen_addr);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for fixing this output. Finally it makes sense to humans!

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You're welcome, fellow human.

@lava lava force-pushed the topic/default-listen-address branch from 3416052 to c2b6977 Compare April 15, 2020 10:32
@lava lava merged commit 1029897 into master Apr 15, 2020
@lava lava deleted the topic/default-listen-address branch April 15, 2020 11:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants