From 28ebc997bfce25e793d24fc2689fe1da60ab23a0 Mon Sep 17 00:00:00 2001 From: "George S. Baugh" Date: Fri, 19 Jan 2018 18:51:51 -0600 Subject: [PATCH] Some of #322: Make safari use at least supported in S::R::D Still need to work on the individual drivers --- lib/Selenium/Remote/Driver.pm | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/lib/Selenium/Remote/Driver.pm b/lib/Selenium/Remote/Driver.pm index e9a9e5a1..7ae3933f 100644 --- a/lib/Selenium/Remote/Driver.pm +++ b/lib/Selenium/Remote/Driver.pm @@ -199,6 +199,8 @@ That said, the following 'sanity tests' in the at/ (acceptance test) directory o =item InternetExplorerDriver : 3.8.1 - at/sanity-ie.test (be sure to enable 'allow local files to run active content in your 'advanced settings' pane) +=item safaridriver : 11.0.2 - at/sanity-safari.test (be sure to enable 'allow automated testing' in the developer menu) -- it appears WC3 spec is *unimplemented* + =back These tests are intended to be run directly against a working selenium server on the local host with said drivers configured. @@ -228,7 +230,7 @@ Desired capabilities - HASH - Following options are accepted: =item B - - Port on which the Webdriver server is listening. Default: 4444 -=item B - - desired browser string: {phantomjs|firefox|internet explorer|MicrosoftEdge|htmlunit|iphone|chrome} +=item B - - desired browser string: {phantomjs|firefox|internet explorer|MicrosoftEdge|safari|htmlunit|iphone|chrome} =item B - - desired browser version number @@ -2359,10 +2361,10 @@ sub add_cookie { 'name' => $name, 'value' => $value, 'path' => $path, - 'domain' => $domain, 'secure' => $secure, } }; + $params->{cookie}->{domain} = $domain if $domain; $params->{cookie}->{'httponly'} = $httponly if $httponly; $params->{cookie}->{'expiry'} = $expiry if $expiry;