Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

return "string" -> croak "string" #42

Merged
merged 1 commit into from Jul 25, 2013

Conversation

Projects
None yet
4 participants

This change should speed debugging when things go wrong by throwing the error immediately on discovery, and bringing the error handling more in line with expectations.

Collaborator

aivaturi commented Sep 20, 2012

Sorry, I just recently moved to a new job & things have been crazy. I promise I'll get to it this weekend.

Thanks. :-)

On Wed, Sep 19, 2012 at 11:36 PM, Aditya Ivaturi
notifications@github.comwrote:

Sorry, I just recently moved to a new job & things have been crazy. I
promise I'll get to it this weekend.


Reply to this email directly or view it on GitHubhttps://github.com/aivaturi/Selenium-Remote-Driver/pull/42#issuecomment-8717264.

@ghost ghost assigned brianmed Mar 28, 2013

@markstos markstos added a commit that referenced this pull request Jul 25, 2013

@markstos markstos Merge pull request #42 from intchanter/master
Update several methods to 'croak' instead of returning a string, better matching our documented behavior and allowing for easier debugging.
65bc16e

@markstos markstos merged commit 65bc16e into teodesian:master Jul 25, 2013

Collaborator

markstos commented Jul 25, 2013

I've reviewed this now, and agree that not only is the change desirable, it is in agreement with existing docs which state: "So a rule of thumb while invoking methods on the driver is if the method did not
croak when called, then you can safely assume the command was successful even if
nothing was returned by the method."

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment