This repository has been archived by the owner on Jul 20, 2023. It is now read-only.
XCode 10.2 / Swift 5, Added AppStore desired 1024x1024 AppIcon #165
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
John-Wolfe-Bose
changed the title
John-Wolfe-Bose
changed the title
|
This looks great. Can we have this please! 🙏 |
|
Absolutely!
John Wolfe
iOS Developer
BOSE
Health Division
Mobile Apps & User Interface
Mobile +1 617 901 2855
From: Stefan Kracht <notifications@github.com>
Reply-To: teodorpatras/EasyTipView <reply@reply.github.com>
Date: Wednesday, September 4, 2019 at 2:01 AM
To: teodorpatras/EasyTipView <EasyTipView@noreply.github.com>
Cc: "Wolfe, John" <John_Wolfe@bose.com>, Author <author@noreply.github.com>
Subject: Re: [teodorpatras/EasyTipView] XCode 10.2 / Swift 5, Added AppStore desired 1024x1024 AppIcon (#165)
This looks great. Can we have this please! 🙏
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub<#165?email_source=notifications&email_token=ALWMXRLFV6XPLYPNAXPGSLTQH5FKHA5CNFSM4HHRVIK2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD52OHKQ#issuecomment-527754154>, or mute the thread<https://github.com/notifications/unsubscribe-auth/ALWMXRNVETOO7HI464GRKDDQH5FKHANCNFSM4HHRVIKQ>.
|
|
Hi! , any updates 🙏🙏🙏? |
|
I think the Travis CI build failed because the code is expecting Xcode 10.2 - and is failing on Xcode 10.1... Also, I can not assign reviewers - so I am not certain what more I can do to get this pull request reviewed and merged! |
|
Travis is actually using |
|
@John-Wolfe-Bose thank you for submitting this PR! I added it to my todo list and will attend to it in the near future! |
|
Unfortunately PR has diverged too much and requires a refactor before merging it. Closed until further notice. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated for Xcode 10.2, Swift 5
Added 1024x1024 Sample App AppStore AppIcon (quiets compiler warning)
NOTE: This will fail CI, unless/until you set up your CI to use XCode 10.2