Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ticket26939 26943 26940 #5

Open
wants to merge 18 commits into
base: master
Choose a base branch
from
Open

Ticket26939 26943 26940 #5

wants to merge 18 commits into from

Conversation

Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@teor2345 @nmathewson
@teor2345
Copy link
Owner

@teor2345 teor2345 commented Sep 21, 2018

No description provided.

teor2345 and others added 18 commits Jul 27, 2018
@teor2345
Conventions: Change SumShares to sum_shares
e14fdda 
Closes 26942.
@teor2345
Remove unused imports
60113d9 
This warning is spuious and disappears on nightly:
warning: field is never used: `client_key`

Closes 26946.
@teor2345
Merge branch 'bug26946' into no-warn
fe5a449
@teor2345
rustc: fail the build on any warning
1360acb 
But allow a spurious dead_code warning for ClientData.client_key.

Part of 26956.
@teor2345
rustc: enable some additional warnings
5a6940a 
And remove:
* an unnecessary qualification, and
* a trivial cast.

Part of 26956.
@nmathewson
Audit and reduce occurrences of usize.
ea1f60f 
We want to use usize for counting elements in a buffer or in a
vector.  But for system parameters like "k" or "n" or the number of
counters, we use u32, for consistency across systems.

This patch is incomplete, since we need to change some APIs. I'll do
that in the next commit.
@nmathewson
Make CounterSet::new() return a Result.
c589bae 
This way it can check for parameters that would overflow u32.
@nmathewson
Stop using assert!() outside of the tests.
7234bb5 
This doesn't fix our unwrapping usage, though.
@nmathewson
Remove all non-test unwrap() calls.
e4046d9
@nmathewson
Add bounds checking for a couple of parameters
fd2c6f0
@nmathewson
Document some of math.rs
78d10bb
@nmathewson
Add doctests for FE, and improve the FE Rand implementation
d765502
@nmathewson
Docs and examples for shamir module
7d536a1 
Also, require that no TR has X coordinate of zero -- otherwise
somebody's share would be the secret value!
@nmathewson
Document the data and encrypt modules
22a08ce
@nmathewson
Document client and server module
48ef9ca
@nmathewson
Enable deny(missing_docs), and fill in the rest of the documentation
7d5a1ac
@nmathewson
Replace an older short README with a new short README
3d4b1e7
@nmathewson
Fix two typos that teor found
9a10c01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment