Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
Improved data handling for LanguagesPageFieldValue at module installa… #11
The current version does not seem to include fields of class "LanguagesPageFieldValue"(like TextAreaLanguage or TextLanguage") at the initial creation of the database table "version_control_data". The revisions are stored in "version_control_revision" but the entries for the unchanged, original data field is not included in the table "version_control_data".
referenced this pull request
Apr 11, 2017
Hi there, @happy-kaseem! After going through some of the changes here, I must admit that I don't really know what to do with this PR :)
There are definitely some good things here that I might be able to merge as-is, but some parts will need to be fixed or tweaked a bit before merging, and some parts I might prefer to solve in a different way altogether.
The main problem here is that this single PR contains multiple unrelated fixes/changes. I hope you don't mind, but I may have to split them up myself and commit them manually. If I do that, GitHub can't connect them directly to you (i.e. give you credit for the commits), but I'll definitely mention you in the commit messages.
Either way, thanks for your input here. It's very much appreciated :)
Closing this PR for now. Some of the things here, I believe, were already implemented, and others will have to wait for the 2.0 version of the module. This will likely be a pretty big change, so I'd rather move all remaining "non-critical" features (including better multilanguage and Repeater support) there.