@ #17 | should install ansible through pip in guest mode #18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
assigned 
|
please check this PR! Thank you! |
hoatle
requested changes
Nov 20, 2018
hieptranquoc
force-pushed
the
task/#17-should-install-ansible-through-pip
branch
from
a1dd643
to
d69e7af
Compare
|
@hoatle I've updated. Please check this PR again. Thank you! |
hoatle
reviewed
Nov 21, 2018
hoatle
reviewed
Nov 21, 2018
hoatle
requested changes
Nov 21, 2018
There was a problem hiding this comment.
@hieptranquoc pls check my comments, never forget backward compatibility changes.
hieptranquoc
force-pushed
the
task/#17-should-install-ansible-through-pip
branch
from
d69e7af
to
05a3e99
Compare
|
@hoatle I've updated. Please check this PR again.! |
hoatle
requested changes
Nov 21, 2018
|
|
||
| if certs_config['ansible']['mode'] == 'guest' | ||
| ansible_install_mode = certs_config['ansible']['install_mode'] | ||
| ansible_install_mode = 'pip' unless TeracyDev::Util.exist?(certs_config['ansible']['install_mode']) |
There was a problem hiding this comment.
set the default "pip" for yaml config instead (to fix #12)
| "_id" => "certs-ansible", | ||
| "type" => ansible_type, | ||
| "extra_vars" => extra_vars, | ||
| "install_mode" => ansible_install_mode, |
There was a problem hiding this comment.
set install_mode if ansible_install_mode is valid (not empty)
| ansible_install_mode = 'pip' unless TeracyDev::Util.exist?(certs_config['ansible']['install_mode']) | ||
|
|
||
| ansible_install_version = certs_config['ansible']['version'] | ||
| ansible_install_version = 'latest' unless TeracyDev::Util.exist?(certs_config['ansible']['version']) |
There was a problem hiding this comment.
don't set "latest" as default (similar to the related issue on teracy-dev-k8s)
| "type" => ansible_type, | ||
| "extra_vars" => extra_vars, | ||
| "install_mode" => ansible_install_mode, | ||
| "version" => ansible_install_version |
There was a problem hiding this comment.
set this only if ansible_install_version is valid (not empty)
|
merged, I'm going to add more improvements later on. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
connect #17
related teracyhq-incubator/teracy-dev-entry-k8s#10