Skip to content

/ flask-classful

forked from apiguy/flask-classy
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Breaking change re FlaskView.decorators missing in CHANGELOG (for v0.11.0) #49

Closed
wodow opened this issue Jul 26, 2017 · 2 comments
Closed

Breaking change re FlaskView.decorators missing in CHANGELOG (for v0.11.0) #49

wodow opened this issue Jul 26, 2017 · 2 comments
Assignees
@hoatle
Labels
comp:docs prio:major reso:fixed type:task
Milestone
v0.14.0-flask-c

Comments

@wodow
Copy link

@wodow wodow commented Jul 26, 2017 •
edited

686be6e changes the order in which decorators are applied, due to the introduction of reversed().

This should be noted as a breaking change in the CHANGELOG?
@hoatle
Copy link
Member

@hoatle hoatle commented Jul 26, 2017

I missed this, I'll update the CHANGLOG accordingly, thank you for reporting this.
@hoatle hoatle self-assigned this Jul 26, 2017
@hoatle hoatle added this to the 0.14.0 milestone Jul 26, 2017
@wodow
Copy link
Author

@wodow wodow commented Jul 26, 2017 •
edited

@hoatle hoatle added sprt:current and removed sprt:next labels Aug 1, 2017
hoatle added a commit to hoatle/flask-classful that referenced this issue Sep 9, 2017
@hoatle
@ teracyhq#49 | Breaking change re FlaskView.decorators missing in CH…
Loading status checks…
cd1773c 
…ANGELOG
@hoatle hoatle changed the title Breaking change re FlaskView.decorators missing in CHANGELOG (for v0.13.1) Breaking change re FlaskView.decorators missing in CHANGELOG (for v0.11.0) Sep 9, 2017
hoatle added a commit to hoatle/flask-classful that referenced this issue Sep 9, 2017
@hoatle
@ teracyhq#49 | Breaking change re FlaskView.decorators for v0.11.0 m…
Loading status checks…
f6a4b62 
…issing in CHANGELOG
@hoatle hoatle mentioned this issue Sep 9, 2017
Merged
@ghost ghost added stag:under-review and removed stag:in-progress labels Sep 9, 2017
hoatle added a commit to hoatle/flask-classful that referenced this issue Sep 9, 2017
@hoatle
@ teracyhq#49 | Breaking change re FlaskView.decorators for v0.11.0 m…
Loading status checks…
2db3024 
…issing in CHANGELOG
hoatle added a commit to hoatle/flask-classful that referenced this issue Sep 9, 2017
@hoatle
@ teracyhq#49 | Breaking change re FlaskView.decorators for v0.11.0 m…
Loading status checks…
ea50e33 
…issing in CHANGELOG
hoatle added a commit to hoatle/flask-classful that referenced this issue Sep 9, 2017
@hoatle
@ teracyhq#49 | Breaking change re FlaskView.decorators for v0.11.0 m…
Loading status checks…
4b9d355 
…issing in CHANGELOG
hoatle added a commit that referenced this issue Sep 9, 2017
@hoatle
Merge pull request #54 from hoatle/tasks/#49-breaking-changes-for-cha…
Loading status checks…
833c7a0 
…ngelog

@ #49 | Breaking change re FlaskView.decorators for v0.11.0 missing in CHANGELOG
@hoatle hoatle added the reso:fixed label Sep 21, 2017
@hoatle hoatle closed this Sep 26, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@hoatle hoatle

Labels
comp:docs prio:major reso:fixed type:task
Projects
None yet
Milestone
v0.14.0-flask-c
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants
@hoatle @wodow
You can’t perform that action at this time.