This repository was archived by the owner on Mar 16, 2025. It is now read-only.
Handle provider errors when refreshing tokens #53
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A provider I'm implementing custom OAuth support for is returning a 400 when refreshing a token. For context, this is the full error body from the service:
However
oauth2_clientswallows this error and continues on as if the response was a success, eventually causing a hard-to-understand error later, whentknResp.isBearer()is called on a response that has no token in it:This branch adds an explicit check for an error response, and throws an exception with more helpful information if so.