New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change enum assoc values to Config for consistency, remove <*> op #5

Merged
merged 1 commit into from Oct 21, 2015

Conversation

Projects
None yet
2 participants
@SixFiveSoftware
Contributor

SixFiveSoftware commented Oct 21, 2015

Config: Just used the type-aliased Config type rather than explicitly stating the
params and their types again, for consistency.
<>: Great operator, but in this case the <^> and <> ops both have the same
signature, and do the exact same thing ultimately, so <*> is not needed.

Change enum assoc values to Config for consistency, remove unnecessar…
…y <*> operator.

Config: Just used the type-aliased Config type rather than explicitly stating the
params and their types again, for consistency.
<*>: Great operator, but in this case the <^> and <*> ops both have the same
signature, and do the exact same thing ultimately, so <*> is not needed.

terhechte added a commit that referenced this pull request Oct 21, 2015

Merge pull request #5 from SixFiveSoftware/fix/refactor_functional_Co…
…nfig_example

Change enum assoc values to Config for consistency, remove <*> op

@terhechte terhechte merged commit 23f36e2 into terhechte:master Oct 21, 2015

@terhechte

This comment has been minimized.

Show comment
Hide comment
@terhechte

terhechte Oct 21, 2015

Owner

Good Idea, thanks for the PR. That nicely simplifies this example.

Owner

terhechte commented Oct 21, 2015

Good Idea, thanks for the PR. That nicely simplifies this example.

@SixFiveSoftware

This comment has been minimized.

Show comment
Hide comment
@SixFiveSoftware

SixFiveSoftware Oct 21, 2015

Contributor

👍 Great article! Thanks for sharing.

Contributor

SixFiveSoftware commented Oct 21, 2015

👍 Great article! Thanks for sharing.

@SixFiveSoftware SixFiveSoftware deleted the SixFiveSoftware:fix/refactor_functional_Config_example branch Oct 21, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment