Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Git bash shows "invisible" fields #142

Open
psachs21 opened this issue Feb 19, 2019 · 5 comments

Comments

Projects
None yet
4 participants
@psachs21
Copy link

commented Feb 19, 2019

I've configured a prompt, something like the following:

const config = await prompts([
        {
          name: "password",
          type: "invisible",
          message: "Enter your password",
          validate: i => !!i
        }
]);

This works fine on mac (and presumably other linux systems) but when running in git bash on windows 7 (or 10), the password field is not invisible and the text reads as plain text.

It does work fine in cmd or powershell.

Is this intended?

@terkelg terkelg added the bug label Feb 24, 2019

@lumio

This comment has been minimized.

Copy link
Collaborator

commented Mar 11, 2019

Sorry for the late response.

I just tried your exact script and cannot reproduce it. It hides all characters as you type.

What version of prompts do you use?

@psachs21

This comment has been minimized.

Copy link
Author

commented Mar 12, 2019

Currently using version 2.0.2. Not sure how it would make a difference but i am running it on a VM, connected through my mac with microsoft remote desktop. This might be so niche it might not be worth dealing with. It is a pretty new version of git bash, don't know how to get the exact version though.

@Exotelis

This comment has been minimized.

Copy link

commented Apr 3, 2019

I am encountering the same problem. I'm using version 2.0.4 on Windows 10 with GitBash Version 2.21.0. Tested this with node version is v8.10.0 and v10.15.3

@lumio

This comment has been minimized.

Copy link
Collaborator

commented Apr 3, 2019

Thank you @Exotelis for this additional confirmation.
Could you create a repository, so we can more easily reproduce this issue?

@Exotelis

This comment has been minimized.

Copy link

commented Apr 4, 2019

I also noticed that the Git Bash get stuck if type confirm is used. I'm going to publish the code soon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.