Skip to content

add WOQLQuery.date #369

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Oct 20, 2022
Merged

add WOQLQuery.date #369

merged 4 commits into from
Oct 20, 2022

Conversation

Francesca-Bit
Copy link
Contributor

@rrooij
Copy link
Contributor

rrooij commented Oct 20, 2022

It should pass the linter. You can run tox -e check to check for the linting errors.

@Francesca-Bit
Copy link
Contributor Author

linting errors checked, please merge the pull request

@codecov
Copy link

codecov bot commented Oct 20, 2022

Codecov Report

Merging #369 (01d1bc0) into main (1d04acc) will increase coverage by 0.04%.
The diff coverage is 50.00%.

@@            Coverage Diff             @@
##             main     #369      +/-   ##
==========================================
+ Coverage   70.02%   70.06%   +0.04%     
==========================================
  Files          11       11              
  Lines        3806     3812       +6     
==========================================
+ Hits         2665     2671       +6     
  Misses       1141     1141              
Impacted Files Coverage Δ
terminusdb_client/woqlquery/woql_query.py 50.96% <50.00%> (+0.28%) ⬆️
terminusdb_client/woql_type.py 81.48% <0.00%> (-1.24%) ⬇️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@rrooij
Copy link
Contributor

rrooij commented Oct 20, 2022

I'm generally more in favor of separate functions for different types, instead of checking the types in the function itself. Still approved because it is better than having no date function now.

@rrooij rrooij merged commit bdeaef5 into main Oct 20, 2022
@rrooij rrooij deleted the review branch October 20, 2022 13:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants