Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

documents provider: mime type map fails with .JPG #721

Closed
chrysn opened this issue Jun 13, 2018 · 1 comment
Closed

documents provider: mime type map fails with .JPG #721

chrysn opened this issue Jun 13, 2018 · 1 comment

Comments

@chrysn
Copy link

chrysn commented Jun 13, 2018

The mime type for .JPG files exported to the Storage Access Framework via the documents provider is the fallback application/octet-stream; thus, image viewers won't open it.

Given that file extensions are usually case insensitive and the library appears to only recognize lower-case variants (tried .html, .doc and .txt), and that digital cameras often store uppercase letters, I suggest that lowercasing the extension before here as a mitigation.

(I can't tell whether there might be better ways than using webkit's mimetypemap (maybe libmagic?) -- but lowercasing would mitigate the immediate issue).

Thank you for maintaining termux and the documents provider; it makes dealing with the android file system limitations much better!

@fornwall
Copy link
Member

fornwall commented Jun 14, 2018

Thanks! This has been fixed in version 0.61 of the app, which has now been released and should be available in Google Play within a few hours (and on F-Droid within a day or so)!

@ghost ghost locked and limited conversation to collaborators Oct 17, 2021
AdamMickiewich pushed a commit to VolyaTeam/dzida-app that referenced this issue Aug 8, 2022
shrihankp pushed a commit to reisxd/termux-app that referenced this issue Oct 20, 2022
frikke pushed a commit to frikke/termux-app that referenced this issue Aug 20, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants