Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.
Sign upsessions: failsafe session is now accessible via separate launcher icon #1028
Conversation
Also enables session autoclosing so no more "annoying" messages about "process completed - press enter". There autoclosing will be performed on exit codes '0' and '130'. On Android TV devices old behaviour will be used - auto close enabled for all sessions when amount of running sessions >1.
This comment has been minimized.
This comment has been minimized.
@fornwall I also made auto-closing for only "0" and "130" exit codes as we discussed on Gitter. |
This comment has been minimized.
This comment has been minimized.
eladts
commented
Apr 14, 2019
I don't like the solution of another launcher icon, it just creates clutter IMHO. Is there a reason why this functionality cannot be achieved using app shortcuts? Is there a way (without rooting) to remove the extra icon from the launcher? |
This comment has been minimized.
This comment has been minimized.
Not all launchers support shortcuts. Especially on older Android versions.
Check launcher settings if it allows to hide icon. Generally, this solution is final and should be fine for average user, i.e. should work on all ROMs and launchers. |
This comment has been minimized.
This comment has been minimized.
btw, there always will be tradeoff for issues regarding "[Process completed - press Enter]" which will not be accepted by some users. Decide what you want:
|
This comment has been minimized.
This comment has been minimized.
eladts
commented
Apr 14, 2019
Thanks @xeffyr for the quick response! Unfortunately my launcher (stock launcher on Moto X4) does not support app hiding and I don't want to switch launchers for this reason alone. I would appreciate if there is an option to hide the extra launcher icon from within Termux, which as far as I understand the only way this can be done without rooting or switching to another launcher. |
xeffyr commentedFeb 11, 2019
•
edited
Enables additional launcher icon that causes to be a failsafe session to be started instead of default.
This PR also makes session auto-closeable on exit coded 0 and 130. Any other exit codes should be handled by user on it's own in order to avoid messages about "Press enter".
Old "failsafe" session button left untouched since it may be useful in some cases to start system shell instead of Termux's one.