Make ExtraKeysView work on Android 5 #132
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is done by explicitly specifying alignment as GridLayout.FILL as I have figured out that this was fixed in Android 6 in commit https://android.googlesource.com/platform/frameworks/base/+/6dafd87fb4174447018b044bc67818d54fab57d8%5E%21/#F0 which set default alignment to FILL if weight is nonzero
|
Awesome find, really nice work! The change is in the |
shrihankp
pushed a commit
to reisxd/termux-app
that referenced
this pull request
Oct 20, 2022
…nment Make ExtraKeysView work on Android 5
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On Android 5 ExtraKeysView shows empty (though can be swiped for TextView).
This is fixed by explicitly specifying alignment as GridLayout.FILL
I have figured out that this was fixed in Android 6 in commit
https://android.googlesource.com/platform/frameworks/base/+/6dafd87fb4174447018b044bc67818d54fab57d8%5E%21/#F0
which set default alignment to FILL if weight is nonzero