Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Static libraries #4028

Closed
twaik opened this issue Jul 8, 2019 · 9 comments

Comments

@twaik
Copy link

commented Jul 8, 2019

Hi! For now termux removes static libraries if package does not need it. I want to suggest a new way: keep static libraries, but pack it only into *-dev packages. It will be usable for some users that really need it on device (i.e. me :) ) or during build in another package

@Grimler91

This comment has been minimized.

Copy link
Member

commented Jul 11, 2019

We could also split it into another subpackage, so having for example libfoo-static

@twaik

This comment has been minimized.

Copy link
Author

commented Jul 11, 2019

That would be wonderful.

@twaik

This comment has been minimized.

Copy link
Author

commented Jul 12, 2019

If static libraries would be subpackages are they available during ./build-package ?

@xeffyr

This comment has been minimized.

Copy link
Member

commented Jul 12, 2019

Static libraries will be available if --disable-static (which is default for now) argument is not passed to configure script.

There no matter will be they available as subpackages or not, splitting is done only after build is finished and doesn't affect existing build/install directories.

@twaik

This comment has been minimized.

Copy link
Author

commented Jul 12, 2019

I think static library should be part of *-dev package. If program needs to be built with static package it also needs library headers.

@Grimler91

This comment has been minimized.

Copy link
Member

commented Jul 12, 2019

If static libraries would be subpackages are they available during ./build-package ?

Subpackages are to dependencies are automatically pulled in when building (with and without -i)

I think static library should be part of *-dev package. If program needs to be built with static package it also needs library headers.

The opposite is not true however, if a program needs the library headers they don't necessarily need the static library. It would increase the -dev package's size significantly if we added the static libraries to them.

@twaik

This comment has been minimized.

Copy link
Author

commented Jul 12, 2019

Ok. So libfoo-static package needs libfoo-dev package. Isn't it?

@Grimler91

This comment has been minimized.

Copy link
Member

commented Jul 13, 2019

Well it's not very useful without it at least. We could make libfoo-static depend on libfoo-dev

@xeffyr

This comment has been minimized.

Copy link
Member

commented Jul 28, 2019

Implemented as part of 21b96d3.

@xeffyr xeffyr closed this Jul 28, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.