Add package for Dungeon Crawl Stone Soup #10916
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Archenoth
requested review from
finagolfin,
Grimler91,
landfillbaby and
thunder-coding
as code owners
|
Looks good, but please rewrite the commit message. Preferably the message should mention which package is affected, and what the commit does, so instead of (see git history for format(s) of previous commit messages) |
Archenoth
force-pushed
the
crawl
branch
2 times, most recently
from
49188d8 to
6c8a469
Compare
|
Alright! I squashed the commits together since they haven't added yet and attempted to emulate the common format for the original commit log message based on what I saw others doing Does this look okay..? |
This package is for the roguelike game Dungeon Crawl Stone Soup
|
Looks great, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ages ago I made this pull in the games repo, but after noticing some architecture-dependent build weirdness, I figured it shouldn't be merged until I figured that out.....then I kinda fell off the planet.
But I tried again recently, and managed to figure out how to get this to build on all architectures!
There was some Makefile weirdness, and I had to rpath the libraries so cross compiling wouldn't cause the linker to not know where to find its shared libraries, but we now have a working version of DCSS that can finally be added to the repos~ ^^