Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[android-5] termux-upgrade-repo: fix shebang, and only try to install packages that are installable #3936

Merged
merged 2 commits into from Jun 9, 2019

Conversation

Projects
None yet
3 participants
@Grimler91
Copy link
Member

commented Jun 9, 2019

Use comm to get intersection of packages_to_install and installable_packages. Works with both busybox and coreutils comm.

Should get rid of errors that packages can't be found.

termux-upgrade-repo: fix shebang, and only install packages that are …
…installable

Use comm to get intersection of packages_to_install and installable_packages. Works with both busybox and coreutils comm.

@Grimler91 Grimler91 requested a review from xeffyr Jun 9, 2019

@xeffyr

This comment has been minimized.

Copy link
Member

commented Jun 9, 2019

Worked okay.

@xeffyr

xeffyr approved these changes Jun 9, 2019

@xeffyr

This comment has been minimized.

Copy link
Member

commented Jun 9, 2019

No. Still not working properly.
Just verified installed packages - ones from unstable-repo and x11-repo are not getting installed.

@Grimler91

This comment has been minimized.

Copy link
Member Author

commented Jun 9, 2019

@xeffyr Not getting installed as in they don't appear in the apt install command or as in the apt install command fails?

I've only tried it from an android 7 device but x11 packages and unstable-packages seem to be included in the apt install list

@Grimler91

This comment has been minimized.

Copy link
Member Author

commented Jun 9, 2019

Ah, I think I understand where I messed up now. Can't use the same dpkg-query to get list of reinstallable packages after rm -rf $PREFIX

@xeffyr

This comment has been minimized.

Copy link
Member

commented Jun 9, 2019

termux-reinstall.sh was executed without error but packages from additional repositories were not re-installed.

@Grimler91

This comment has been minimized.

Copy link
Member Author

commented Jun 9, 2019

@xeffyr Could you give it another shot when you have time?

@xeffyr

This comment has been minimized.

Copy link
Member

commented Jun 9, 2019

Now works.

@xeffyr

xeffyr approved these changes Jun 9, 2019

@Grimler91 Grimler91 changed the title termux-upgrade-repo: fix shebang, and only try to install packages that are installable [android-5] termux-upgrade-repo: fix shebang, and only try to install packages that are installable Jun 9, 2019

@fornwall fornwall merged commit a1d6718 into android-5 Jun 9, 2019

4 checks passed

build TERMUX_ARCH:aarch64 Task Summary
Details
build TERMUX_ARCH:arm Task Summary
Details
build TERMUX_ARCH:i686 Task Summary
Details
build TERMUX_ARCH:x86_64 Task Summary
Details

@xeffyr xeffyr deleted the termux-upgrade-repo branch Jun 10, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.