Tern server.reset isn't deleting files

[MiguelCastillo]

Is server.reset supposed to delete all the files? If it is supposed to, then we have a bug.

[marijnh]

This is the intended behavior. reset flushes the type graph, but keeps the files that were added around. It is indended to be a thing that happens silently in the background when the graph has gotten messy from too many purge/analyze cycles, and shouldn't have visible side effects except for possibly cleaner results in the next request.

[MiguelCastillo]

The primary use case I am looking at is switching projects; most likely data does not carry from project to project. So, I am manually setting server.files = [] when switching projects; I am also calling reset as that seemed like a natural call to make. Perhaps reset and clearing all files (along with whatever else you might want to clean up) can be put in a function? Maybe clear(), clearAll()? I don't your preference.

I am not big into making pull request for such small items, but if you would like I can add a clear function and make a pull request for ya. Or if you have a better approach, I would really like to hear about it.

[marijnh]

Create a new server for each project. I don't think there's anything added by being able to re-purpose an existing server object.

[MiguelCastillo]

Alright, simple enough. I am always skeptical about creating new objects that are called "server", which is why I didn't do it before. But if you are suggesting it, then it must be safe to do :-)

Thanks!

[marijnh]

Yes, definitely safe. This is not a singleton, and there's no global data involved.